Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map faas.* attributes to generic_task in resource mapping #735

Closed
dashpole opened this issue Oct 11, 2023 · 2 comments · Fixed by #764
Closed

Map faas.* attributes to generic_task in resource mapping #735

dashpole opened this issue Oct 11, 2023 · 2 comments · Fixed by #764
Assignees
Labels
enhancement New feature or request priority: p1

Comments

@dashpole
Copy link
Contributor

Implement GoogleCloudPlatform/opentelemetry-operations-python#273 in the resource mapping in this repository.

@dgnemo
Copy link

dgnemo commented Oct 31, 2023

idk if this issue refers to the same problem I am describing below, but I am going to report it anyway :)

As I was reading the code to understand why cloud_run metrics are logged as generic_node instead of generic_task
I came to believe that every instance of semconv.FaaSIDKey in
https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/main/internal/resourcemapping/resourcemapping.go
should actually be changed to semconv.FaaSInstanceKey

Any thoughts on this?

@dashpole
Copy link
Contributor Author

dashpole commented Nov 1, 2023

You are correct. That was definitely an oversight during #679. I'll make sure that is fixed as well. Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: p1
Projects
None yet
2 participants