Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace through Cloud Pub/Sub #104

Closed
davedc opened this issue Jun 25, 2020 · 4 comments
Closed

Trace through Cloud Pub/Sub #104

davedc opened this issue Jun 25, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@davedc
Copy link

davedc commented Jun 25, 2020

Is your feature request related to a problem? Please describe.
Trace context is not passed in on publish on a topic. This leads to detached spans created on subscribers.

Describe the solution you'd like
A @opentelemetry/plugin-gcp-pubsub and a GCPPubSubPropagator class to automatically inject and extract Context.

Describe alternatives you've considered
Manually injecting the trace context via Message attributes but no way to extract on the other side.

Additional context
Am expecting something similar to this googleapis/cloud-trace-nodejs#1076 (comment) without manually having to create spans.

Please kindly point me to the right place if this isn't the correct repo to submit this feature request. Thanks!

@punya punya added the enhancement New feature or request label Feb 1, 2021
@punya
Copy link
Contributor

punya commented Apr 1, 2021

Is this solved by googleapis/nodejs-pubsub#1078?

@aabmass
Copy link
Contributor

aabmass commented Apr 1, 2021

Yes, pubsub node is instrumented directly now 🙂 I'm going to close this

@aabmass aabmass closed this as completed Apr 1, 2021
@weyert
Copy link

weyert commented Apr 2, 2021

Yes, this ticket can be closed, but love to get some feedback from Google Trace Opentelemetry team about the attributes I am sending and if it matches what the spec had it mind. I think in future releases of google-pubsub improvements can be made :)

@aabmass
Copy link
Contributor

aabmass commented Apr 5, 2021

I'll take a look at the pubsub PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants