Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ValueRecorder export #176

Closed
nicolasgere opened this issue Sep 30, 2020 · 2 comments
Closed

Support ValueRecorder export #176

nicolasgere opened this issue Sep 30, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers monitoring

Comments

@nicolasgere
Copy link

nicolasgere commented Sep 30, 2020 •
edited
Loading

Please answer these questions before submitting a bug report.

What version of OpenTelemetry are you using?

0.10.2

What version of Node are you using?

10.4

What did you do?

Just want to use ValueRecorder

What did you expect to see?

What did you see instead?

Additional context

Based on

opentelemetry-operations-js/packages/opentelemetry-cloud-monitoring-exporter/src/transform.ts

Line 92 in 07da521

// OTMetricKind.Measure was renamed to ValueRecorder in #1117
it will be done. Do you know when? do you know a work around?
@nicolasgere nicolasgere added the bug Something isn't working label Sep 30, 2020
@aabmass
Copy link
Contributor

aabmass commented Sep 30, 2020 •
edited
Loading

The aggregation behavior for ValueRecorder is under a lot of debate in the spec open-telemetry/opentelemetry-specification#636. It looks it will probably change to some sort of Histogram or sketch. That said, we could probably send LastValue that is currently given in OTel JS.

@aabmass aabmass added enhancement New feature or request good first issue Good for newcomers labels Sep 30, 2020
@aabmass
Copy link
Contributor

aabmass commented Feb 1, 2021

Duplicate of #129, closing in favor of that issue

@aabmass aabmass closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers monitoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@punya @aabmass @nicolasgere