Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace-exporter)!: send span kind to cloud trace #293

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Jun 23, 2021

BREAKING CHANGE: add span kind is now sent with traces.

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #293 (e9f00ab) into master (c7c0d95) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage   95.86%   96.08%   +0.22%     
==========================================
  Files          12       12              
  Lines         387      409      +22     
  Branches       71       78       +7     
==========================================
+ Hits          371      393      +22     
  Misses         16       16              
Impacted Files Coverage Δ
...pentelemetry-cloud-trace-exporter/src/transform.ts 98.05% <100.00%> (+0.33%) ⬆️
...es/opentelemetry-cloud-trace-exporter/src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c0d95...e9f00ab. Read the comment docs.

@aabmass aabmass marked this pull request as ready for review June 23, 2021 19:16
@aabmass aabmass requested a review from a team June 23, 2021 19:16
@aabmass aabmass changed the title feat(trace-exporter): send span kind to the api feat(trace-exporter): send span kind to cloud trace Jun 23, 2021
Copy link
Contributor

@punya punya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, but looks good overall.

packages/opentelemetry-cloud-trace-exporter/src/types.ts Outdated Show resolved Hide resolved
packages/opentelemetry-cloud-trace-exporter/src/types.ts Outdated Show resolved Hide resolved
@aabmass aabmass changed the title feat(trace-exporter): send span kind to cloud trace feat(trace-exporter)!: send span kind to cloud trace Jun 24, 2021
@aabmass aabmass merged commit 1ca9844 into GoogleCloudPlatform:master Jun 24, 2021
@aabmass aabmass deleted the span-kind branch June 24, 2021 15:04
@weyert
Copy link

weyert commented Jun 25, 2021

This PR sounds interesting @aabmass Does this in any change the way the span is represented in Google Trace UI?

@aabmass
Copy link
Contributor Author

aabmass commented Jun 28, 2021

I don't think the UI shows span kind at the moment, but it is definitely saved in the backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants