Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR contribution 291 - refactor modules/logging-center/main.tf hardcoded services list out into env/common tfvars #314

Closed
obriensystems opened this issue Sep 18, 2023 · 1 comment

Comments

@obriensystems
Copy link
Collaborator

See example implementation fix in the two for audit and guardrails
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/pull/291/files#diff-cb9302fb17255576bca335da2817cda2a821b776209c180f929f6527396f89fd

services                                = ["storage.googleapis.com", "logging.googleapis.com", "monitoring.googleapis.com"]

Hardcoded service list needs to move out of modules into a tfvar in environments/common
For an example fix - see #284 - 2 PRs as reference

https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/pull/310/files#diff-acb71cc23936666b11db107a6fe60a986ed76ee48c2150b4e035b7519b4e973dR83

#313

@fmichaelobrien
Copy link
Contributor

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards
This issue may participate in the LZ refactor after rebase
Query on all issues related to the older V1 version via the tag
2024-pre-tef-v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants