Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage session state #305

Merged
merged 6 commits into from
Aug 7, 2022
Merged

feat: manage session state #305

merged 6 commits into from
Aug 7, 2022

Conversation

olavloite
Copy link
Collaborator

Support SHOW, SET and RESET commands for session variables. The session state
is not used, but all supported SHOW/SET/RESET commands from PostgreSQL are
supported. The transactionality of these statements follow the rules of
PostgreSQL.

Support SHOW, SET and RESET commands for session variables. The session state
is not used, but all supported SHOW/SET/RESET commands from PostgreSQL are
supported. The transactionality of these statements follow the rules of
PostgreSQL.
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #305 (f042294) into postgresql-dialect (32986c0) will increase coverage by 0.13%.
The diff coverage is 85.89%.

@@                   Coverage Diff                    @@
##             postgresql-dialect     #305      +/-   ##
========================================================
+ Coverage                 83.04%   83.17%   +0.13%     
- Complexity                 1338     1430      +92     
========================================================
  Files                       109      109              
  Lines                      4617     4982     +365     
  Branches                    574      640      +66     
========================================================
+ Hits                       3834     4144     +310     
- Misses                      596      628      +32     
- Partials                    187      210      +23     
Flag Coverage Δ
all_tests 83.17% <85.89%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ud/spanner/pgadapter/utils/ClientAutoDetector.java 92.68% <ø> (ø)
...r/pgadapter/statements/SessionStatementParser.java 73.78% <73.78%> (ø)
...gle/cloud/spanner/pgadapter/session/PGSetting.java 91.47% <91.47%> (ø)
...panner/pgadapter/statements/BackendConnection.java 91.19% <95.00%> (-0.07%) ⬇️
.../cloud/spanner/pgadapter/session/SessionState.java 100.00% <100.00%> (ø)
...oud/spanner/pgadapter/statements/SimpleParser.java 92.10% <0.00%> (+0.87%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@olavloite olavloite changed the title Session state feat: manage session state Jul 31, 2022
@olavloite olavloite marked this pull request as ready for review July 31, 2022 15:46
@olavloite olavloite merged commit 9e4d391 into postgresql-dialect Aug 7, 2022
@olavloite olavloite deleted the session-state branch August 7, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant