-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace pg_catalog tables with common table expressions #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combines the StatementParser and SimpleParser into one parser to reduce code duplication and to make the SimpleParser more complete, as it now also supports skipping comments and dollar-quoted strings.
…eplacement-tables
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #331 +/- ##
========================================================
+ Coverage 83.83% 83.95% +0.12%
- Complexity 1531 1593 +62
========================================================
Files 112 114 +2
Lines 5232 5417 +185
Branches 683 727 +44
========================================================
+ Hits 4386 4548 +162
- Misses 633 643 +10
- Partials 213 226 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
pg_catalog
table references with common table expressions:pg_namespace
is added with two fixed entries.pg_type
is added with 14 fixed entries.This setup can be used to add more
pg_catalog
tables that are needed by drivers / frameworks.