Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add COPY settings to session state #338

Merged
merged 6 commits into from
Sep 10, 2022

Conversation

olavloite
Copy link
Collaborator

Adds COPY settings to the session state so these can be managed using
normal SET/SHOW session commands.

Adds COPY settings to the session state so these can be managed using
normal SET/SHOW session commands.
@olavloite olavloite marked this pull request as ready for review August 28, 2022 08:15
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #338 (1d9325c) into postgresql-dialect (687c952) will increase coverage by 0.05%.
The diff coverage is 98.11%.

@@                   Coverage Diff                    @@
##             postgresql-dialect     #338      +/-   ##
========================================================
+ Coverage                 85.04%   85.10%   +0.05%     
- Complexity                 1648     1669      +21     
========================================================
  Files                       114      115       +1     
  Lines                      5490     5552      +62     
  Branches                    743      754      +11     
========================================================
+ Hits                       4669     4725      +56     
- Misses                      604      606       +2     
- Partials                    217      221       +4     
Flag Coverage Δ
all_tests 85.10% <98.11%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cloud/spanner/pgadapter/utils/MutationWriter.java 92.07% <91.66%> (-0.98%) ⬇️
.../cloud/spanner/pgadapter/session/CopySettings.java 100.00% <100.00%> (ø)
.../cloud/spanner/pgadapter/session/SessionState.java 95.70% <100.00%> (-2.89%) ⬇️
...ud/spanner/pgadapter/statements/CopyStatement.java 84.09% <100.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite olavloite merged commit 31a2faf into postgresql-dialect Sep 10, 2022
@olavloite olavloite deleted the copy-settings-to-session-state branch September 10, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant