Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support null parameters #35

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Conversation

olavloite
Copy link
Collaborator

  • Adds more integration tests using the native PG JDBC driver.
  • Adds support for null values in query parameters.

The PG JDBC driver sends DATE/TIMESTAMP parameters with type code
Oid.UNSPECIFIED. Untyped NULL values are currently not supported by the
Spangres backend, and also not by the Java client library / JDBC driver.
A patch for the Java client library has been submitted here: googleapis/java-spanner#1680

- Adds more integration tests using the native PG JDBC driver.
- Adds support for null values in query parameters.

The PG JDBC driver sends DATE/TIMESTAMP parameters with type code
Oid.UNSPECIFIED. Untyped NULL values are currently not supported by the
Spangres backend, and also not by the Java client library / JDBC driver.
A patch for the Java client library has been submitted here: googleapis/java-spanner#1680
@olavloite olavloite marked this pull request as ready for review February 11, 2022 16:27
Copy link
Collaborator

@Vizerai Vizerai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite enabled auto-merge (squash) February 16, 2022 10:36
@olavloite olavloite merged commit 4fde6c3 into postgresql-dialect Feb 16, 2022
@olavloite olavloite deleted the support-null-parameters branch March 6, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants