Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experimental support for node-postgres #362

Merged
merged 16 commits into from
Oct 12, 2022

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Sep 20, 2022

Adds tests and experimental support for the node-postgres driver. This also includes an additional internal step that will make PGAdapter automatically describe statements that have at least one untyped parameter. The statement description is cached on the connection, so it does not need to execute the additional step each time the statement is encountered.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #362 (6462ebb) into postgresql-dialect (5352f79) will increase coverage by 0.10%.
The diff coverage is 94.23%.

@@                   Coverage Diff                    @@
##             postgresql-dialect     #362      +/-   ##
========================================================
+ Coverage                 86.21%   86.32%   +0.10%     
- Complexity                 1885     1903      +18     
========================================================
  Files                       122      122              
  Lines                      6129     6170      +41     
  Branches                    839      847       +8     
========================================================
+ Hits                       5284     5326      +42     
+ Misses                      605      603       -2     
- Partials                    240      241       +1     
Flag Coverage Δ
all_tests 86.32% <94.23%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ud/spanner/pgadapter/wireprotocol/BindMessage.java 82.50% <75.00%> (-0.84%) ⬇️
...pter/statements/IntermediatePreparedStatement.java 87.21% <94.59%> (+1.20%) ⬆️
...gle/cloud/spanner/pgadapter/ConnectionHandler.java 86.60% <100.00%> (+0.35%) ⬆️
...panner/pgadapter/wireprotocol/DescribeMessage.java 86.11% <100.00%> (+0.39%) ⬆️
...google/cloud/spanner/pgadapter/parsers/Parser.java 84.09% <0.00%> (ø)
...er/pgadapter/statements/IntermediateStatement.java 94.44% <0.00%> (+1.11%) ⬆️
...om/google/cloud/spanner/pgadapter/ProxyServer.java 80.95% <0.00%> (+1.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite olavloite marked this pull request as ready for review October 4, 2022 18:21
@olavloite olavloite changed the title test: add tests for node-postgres feat: add experimental support for node-postgres Oct 12, 2022
@olavloite olavloite merged commit 9e3e952 into postgresql-dialect Oct 12, 2022
@olavloite olavloite deleted the test-node-postgres branch October 12, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant