Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept UUID as a parameter value #518

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

olavloite
Copy link
Collaborator

Some frameworks, such as Hibernate, will assume that the PostgreSQL server supports the UUID type if the version is >= 8.3. This adds support for incoming UUID parameter values. These are converted to STRING values before being sent to Cloud Spanner.

Fixes #517

Some frameworks, such as Hibernate, will assume that the PostgreSQL server
supports the UUID type if the version is >= 8.3. This adds support for
incoming UUID parameter values. These are converted to STRING values before
being sent to Cloud Spanner.

Fixes #517
@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #518 (dda8378) into postgresql-dialect (8f23a48) will increase coverage by 0.04%.
The diff coverage is 95.45%.

❗ Current head dda8378 differs from pull request most recent head db25195. Consider uploading reports for the commit db25195 to get more accurate results

@@                   Coverage Diff                    @@
##             postgresql-dialect     #518      +/-   ##
========================================================
+ Coverage                 87.90%   87.95%   +0.04%     
- Complexity                 2030     2045      +15     
========================================================
  Files                       121      122       +1     
  Lines                      6722     6766      +44     
  Branches                    945      948       +3     
========================================================
+ Hits                       5909     5951      +42     
- Misses                      579      580       +1     
- Partials                    234      235       +1     
Flag Coverage Δ
all_tests 87.95% <95.45%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...le/cloud/spanner/pgadapter/parsers/UuidParser.java 95.34% <95.34%> (ø)
...google/cloud/spanner/pgadapter/parsers/Parser.java 88.11% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite olavloite enabled auto-merge (squash) November 28, 2022 13:41
@olavloite olavloite merged commit 46941ab into postgresql-dialect Nov 28, 2022
@olavloite olavloite deleted the accept-uuid-parameters branch November 28, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UUID parameter values do not work when the returned PG version is >= 8.3
2 participants