Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically add LIMIT clause #792

Merged
merged 8 commits into from
May 4, 2023

Conversation

olavloite
Copy link
Collaborator

Automatically add a LIMIT clause to queries that use an OFFSET clause with a query parameter and no LIMIT clause. That is currently not supported in Cloud Spanner PostgreSQL databases.

This type of queries are generated by Prisma.

Automatically add a LIMIT clause to queries that use an OFFSET clause with
a query parameter and no LIMIT clause. That is currently not supported in
Cloud Spanner PostgreSQL databases.

This type of queries are generated by Prisma.
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #792 (ec81a32) into postgresql-dialect (e0b48ee) will increase coverage by 0.13%.
The diff coverage is 93.93%.

@@                   Coverage Diff                    @@
##             postgresql-dialect     #792      +/-   ##
========================================================
+ Coverage                 89.61%   89.75%   +0.13%     
- Complexity                 2366     2380      +14     
========================================================
  Files                       131      131              
  Lines                      7837     7895      +58     
  Branches                   1122     1132      +10     
========================================================
+ Hits                       7023     7086      +63     
+ Misses                      566      565       -1     
+ Partials                    248      244       -4     
Flag Coverage Δ
all_tests 89.75% <93.93%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oud/spanner/pgadapter/statements/SimpleParser.java 93.78% <92.85%> (+1.38%) ⬆️
.../cloud/spanner/pgadapter/session/SessionState.java 94.92% <100.00%> (+0.02%) ⬆️
...panner/pgadapter/statements/BackendConnection.java 93.92% <100.00%> (+0.26%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite olavloite merged commit c382392 into postgresql-dialect May 4, 2023
25 checks passed
@olavloite olavloite deleted the auto-add-limit-clause branch May 4, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant