Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onboard NOAA #214

Closed
wants to merge 37 commits into from
Closed

feat: Onboard NOAA #214

wants to merge 37 commits into from

Conversation

nlarge-google
Copy link
Collaborator

@nlarge-google nlarge-google commented Oct 21, 2021

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/noaa and nothing outside of that directory.
  • This PR is appropriately labeled.

@google-cla google-cla bot added the cla: yes label Oct 21, 2021
@adlersantos adlersantos added the data onboarding Onboard a dataset or submit a pipeline label Oct 21, 2021
@adlersantos adlersantos self-requested a review October 21, 2021 21:26
@google-cla
Copy link

google-cla bot commented Oct 21, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 21, 2021
@nlarge-google
Copy link
Collaborator Author

@googlebot I consent

@google-cla
Copy link

google-cla bot commented Oct 22, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@adlersantos
Copy link
Member

@googlebot I consent

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 28, 2021
@adlersantos
Copy link
Member

Failing on DEV. Will revisit later

@nlarge-google
Copy link
Collaborator Author

@adlersantos - I fixed the noaa variables in AF, and reran all the DAGs. For some reason a bunch of the DAGs were missing from the variables. Anyway, I reran in AF and all have completed successfully. Please review the code at your earliest convenience. The new entries for lightning strikes are the changes I would like in the repository. Thanks!

@nlarge-google
Copy link
Collaborator Author

@adlersantos Can you please tell me if this went to production? Thanks.

Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of opportunities to DRY out the transform scripts and reduce the containers used for KPodOperators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes data onboarding Onboard a dataset or submit a pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants