New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Onboard NOAA #214
feat: Onboard NOAA #214
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent |
Failing on DEV. Will revisit later |
@adlersantos - I fixed the noaa variables in AF, and reran all the DAGs. For some reason a bunch of the DAGs were missing from the variables. Anyway, I reran in AF and all have completed successfully. Please review the code at your earliest convenience. The new entries for lightning strikes are the changes I would like in the repository. Thanks! |
@adlersantos Can you please tell me if this went to production? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are lots of opportunities to DRY out the transform scripts and reduce the containers used for KPodOperators
… set number [FTP_BATCH_SLEEP_TIME] of seconds.
Checklist
Note: Delete items below that aren't applicable to your pull request.
datasets/noaa
and nothing outside of that directory.