feat: Onboard NASA wildfire #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkodukula
force-pushed
the
new_nasa_wildfire
branch
from
6ed891b
to
3120646
Compare
nlarge-google
requested changes
Mar 9, 2022
datasets/nasa_wildfire/pipelines/_images/run_csv_transform_kub/csv_transform.py
Outdated
Show resolved
Hide resolved
| download_file(source_url, source_file) | ||
|
|
||
| logging.info("Reading file ...") | ||
| df = pd.read_csv(str(source_file)) |
There was a problem hiding this comment.
Should be chunking? What is the typical # records/file size?
datasets/nasa_wildfire/pipelines/_images/run_csv_transform_kub/csv_transform.py
Outdated
Show resolved
Hide resolved
datasets/nasa_wildfire/pipelines/_images/run_csv_transform_kub/csv_transform.py
Outdated
Show resolved
Hide resolved
| TARGET_GCS_BUCKET: "{{ var.value.composer_bucket }}" | ||
| TARGET_GCS_PATH: "data/nasa_wildfire/past_week/data_output.csv" | ||
| PIPELINE_NAME: "past_week" | ||
| CSV_HEADERS: >- |
|
@adlersantos @happyhuman @nlarge-google please review the code after the changes as per review comments |
nlarge-google
requested changes
Mar 18, 2022
adlersantos
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pipeline: past_week
Checklist
Note: Delete items below that aren't applicable to your pull request.
datasets/nasa_wildfireand nothing outside of that directory.