Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Onboard EPA Historical Air Quality dataset #301

Merged
merged 68 commits into from Apr 8, 2022
Merged

Feat: Onboard EPA Historical Air Quality dataset #301

merged 68 commits into from Apr 8, 2022

Conversation

nlarge-google
Copy link
Collaborator

@nlarge-google nlarge-google commented Feb 25, 2022

Description

  • Dataset now utilizes individual clusters in order to resolve resource failures when running on the main cluster

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a feature
    • I have added tests for the feature
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/epa_historical_air_quality and nothing outside of that directory
  • I'm submitting a bugfix
  • I'm refactoring or cleaning up some code

…nting some pipelines to complete successfully.
…atch size in order to resolve memory pressure resulting in DAG failure.
@nlarge-google
Copy link
Collaborator Author

@adlersantos @happyhuman Please review the code changes. The system now implements the new folder structure along with utilizing a cluster create and other changes to improve code.

@adlersantos adlersantos self-requested a review March 21, 2022 17:10
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge these multiple DAGs into one that creates and deletes a single cluster

@nlarge-google
Copy link
Collaborator Author

@adlersantos @happyhuman Please review following latest changes. Thanks!

@adlersantos adlersantos changed the title Feat: Onboard EPA dataset Feat: Onboard EPA Historical Air Quality dataset Apr 8, 2022
@adlersantos adlersantos merged commit 214a56f into GoogleCloudPlatform:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants