Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add geom columns for thelook_ecommerce dataset #307

Merged
merged 3 commits into from Aug 25, 2022

Conversation

shanecglass
Copy link
Contributor

Adding a user_geom and distribution_center column of type GEOGRAPHY to user and distribution_center tables

Description

Dataset updated: datasets/thelook_ecommerce/pipelines/thelook_ecommerce/pipeline.yaml

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/<DATASET_NAME> and nothing outside of that directory

Adding a user_geom and distribution_center column of type GEOGRAPHY to user and distribution_center tables
Cleaning up YAML errors to add geom columns for users and distribution_center tables
Copy link
Contributor Author

@shanecglass shanecglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated based on presubmit test failures

Adding a geom column to the users and distribution_center tables
Copy link
Contributor Author

@shanecglass shanecglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to remove trailing spaces to clear presubmit errors

@adlersantos adlersantos changed the title feat: add geom columns feat: Add geom columns for thelook_ecommerce dataset Mar 14, 2022
@adlersantos adlersantos self-requested a review March 14, 2022 17:35
Copy link
Collaborator

@nlarge-google nlarge-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job Shane!

@nlarge-google nlarge-google merged commit f39a177 into main Aug 25, 2022
@nlarge-google nlarge-google deleted the shanecglass-patch-1 branch August 25, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants