Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onboard Open Targets Platform dataset #313

Merged
merged 24 commits into from Apr 29, 2022

Conversation

gkodukula
Copy link
Collaborator

@gkodukula gkodukula commented Mar 18, 2022

Description

Pipelines included:

  • open_targets,platform

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a feature
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside open_targets/platform and nothing outside of that directory
  • I'm refactoring or cleaning up some code

@gkodukula gkodukula changed the title Open targets platform feat: Onboard Open Targets Platform dataset Mar 21, 2022
@adlersantos
Copy link
Member

Your PR shouldn't include code related to the nasa_wildfire dataset

Copy link
Collaborator

@nlarge-google nlarge-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one change

datasets/open_targets/pipelines/dataset.yaml Outdated Show resolved Hide resolved
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes to use proper namespacing for the Airflow variables. Will merge when the tests pass

@adlersantos adlersantos merged commit c5adce6 into GoogleCloudPlatform:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants