Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Onboard Cloud Storage Geo Index #367

Merged
merged 10 commits into from Jun 2, 2022
Merged

Feat: Onboard Cloud Storage Geo Index #367

merged 10 commits into from Jun 2, 2022

Conversation

nlarge-google
Copy link
Collaborator

@nlarge-google nlarge-google commented May 26, 2022 •
edited

Description

Dataset: cloud_storage_geo_index
Pipelines: landsat_index, sentinel_2_index

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/cloud_storage_geo_index and nothing outside of that directory
  • I'm refactoring or cleaning up some code

@nlarge-google nlarge-google self-assigned this May 26, 2022
@adlersantos adlersantos self-requested a review May 27, 2022 17:42
@adlersantos adlersantos changed the title Feat: Onboard Cloud storage geo index Feat: Onboard Cloud Storage Geo Index May 27, 2022
@nlarge-google
Copy link
Collaborator Author

@adlersantos @happyhuman Please review this dataset. Thanks!

@adlersantos adlersantos added data onboarding Onboard a dataset or submit a pipeline revision: pipeline Revise a pipeline or dataset labels May 27, 2022
adlersantos
adlersantos previously approved these changes Jun 1, 2022
View reviewed changes
adlersantos
adlersantos approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Reminder to deprecate the old pipeline.

@nlarge-google nlarge-google merged commit 63cdb2a into GoogleCloudPlatform:main Jun 2, 2022
@release-please release-please bot mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlersantos adlersantos adlersantos approved these changes

Assignees

@nlarge-google nlarge-google

Labels
data onboarding Onboard a dataset or submit a pipeline revision: pipeline Revise a pipeline or dataset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlarge-google @adlersantos