New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Onboard Human Variant Annotation dataset #438
Feat: Onboard Human Variant Annotation dataset #438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes. Please make the changes and retest.
gcs_bucket: str, | ||
target_gcs_folder: str, | ||
pipeline: str, | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always incorporate a return type. For no return type use:
def fn(...) -> None:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok done
source_url = base_url + f"archive_{version}/{date_time.strftime('%Y')}/{file_name}" | ||
source_file = f"./files/{folder}/{file_name}" | ||
status_code = download_gzfile(source_url, source_file) | ||
if status_code == 200: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else:
pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok done
folder: pathlib.Path, | ||
gcs_bucket: str, | ||
target_gcs_folder: str, | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return type None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job. In future though, please reduce the number of blank lines between code blocks to 0. Thanks!
Description
Dataset: human_variant_annotation pipeline: clinvar
Dataset: human_variant_annotation pipeline: db_snp
Checklist
datasets/human_variant_annotation
and nothing outside of that directory