Feat: Onboard NHTSA Traffic Fatalities dataset #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurogoogle
changed the title
aurogoogle
changed the title
aurogoogle
changed the title
|
@adlersantos @nlarge-google Kindly review. |
nlarge-google
requested changes
Aug 25, 2022
Pipfile
Outdated
| url = "https://pypi.org/simple" | ||
| verify_ssl = true | ||
| name = "pypi" | ||
|
|
There was a problem hiding this comment.
Please remove this file from the branch
There was a problem hiding this comment.
Removed the mentioned file from the commit / branch.
Pipfile.lock
Outdated
| @@ -0,0 +1,20 @@ | |||
| { | |||
There was a problem hiding this comment.
Please remove this file from the branch
There was a problem hiding this comment.
Removed the mentioned file from the commit / branch.
| + "00" | ||
| + " UTC" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Please remove extra lines
There was a problem hiding this comment.
Removed extra spaces.
| append_batch_file( | ||
| target_file_batch, target_file, skip_header, not (skip_header) | ||
| ) | ||
|
|
There was a problem hiding this comment.
Please remove extra lines
There was a problem hiding this comment.
Removed extra spaces.
aurogoogle
force-pushed
the
nhtsa_traffic_fatalities
branch
from
d515289
to
2bd4fcd
Compare
|
Hey @nlarge-google I have addressed the mentioned changes. Kindly review. |
nlarge-google
approved these changes
Aug 25, 2022
|
Great Job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dataset: NHTSA Traffic Fatalities
Checklist
Use the sections below based on what's applicable to your PR and delete the rest:
Feature
READMEaccordinglyData Onboarding
datasets/<nhtsa_traffic_fatalities>and nothing outside of that directory