Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanner.cloud-client.backup_sample_test: test_update_backup failed #3241

Closed
flaky-bot bot opened this issue Mar 31, 2020 · 13 comments · Fixed by #3468 or #3688
Closed

spanner.cloud-client.backup_sample_test: test_update_backup failed #3241

flaky-bot bot opened this issue Mar 31, 2020 · 13 comments · Fixed by #3468 or #3688
Assignees
Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Mar 31, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.


commit: 7bc4783
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 31, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 1, 2020

Test passed for commit 9e64bff (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Apr 1, 2020
@flaky-bot flaky-bot bot reopened this Apr 1, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 1, 2020

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


commit: e943bff
buildURL: Build Status, Sponge
status: failed

@leahecole leahecole assigned mmmarklu and unassigned leahecole Apr 1, 2020
@JustinBeckwith JustinBeckwith added the api: spanner Issues related to the Spanner API. label Apr 2, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 17, 2020
@tmatsuo tmatsuo closed this as completed Apr 21, 2020
@flaky-bot flaky-bot bot reopened this Apr 22, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 22, 2020

Oops! Looks like this issue is still flaky. 😬

I reopened the issue, but a human will need to close it again.


commit: c71f978
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 24, 2020

Oops! Looks like this issue is still flaky. 😬

I reopened the issue, but a human will need to close it again.


commit: 86a552c
buildURL: Build Status, Sponge
status: failed

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 25, 2020

This is a rare backend issue. We may need to have a mitigation if this happens a lot, but for now we close this.

@tmatsuo tmatsuo closed this as completed Apr 25, 2020
@flaky-bot flaky-bot bot reopened this Apr 27, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 27, 2020

Oops! Looks like this issue is still flaky. 😬

I reopened the issue, but a human will need to close it again.


commit: 2b74710
buildURL: Build Status, Sponge
status: failed

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 27, 2020

It seems like the default timeout for create_backup is 30 seconds.

We can add timeout parameter to create_backup call for mitigating the test failure, but it is also too long for the server to return a Long Running Operation. If the server is expected to take more than 30 seconds frequently enough (currently it seems like so), we should change the client library's default value.

@larkee WDYT?

Update: There is a new config for the timeout. I filed googleapis/python-spanner#68

@tmatsuo tmatsuo assigned tmatsuo and unassigned larkee Apr 27, 2020
@tmatsuo tmatsuo removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Apr 27, 2020
@tmatsuo tmatsuo added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 27, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 27, 2020

Blocked by googleapis/python-spanner#68

@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 27, 2020
@flaky-bot flaky-bot bot reopened this May 6, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented May 6, 2020

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 32777eb
buildURL: Build Status, Sponge
status: failed

Test output
Traceback (most recent call last):
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/grpc_helpers.py", line 57, in error_remapped_callable
    return callable_(*args, **kwargs)
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/grpc/_channel.py", line 826, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/grpc/_channel.py", line 729, in _end_unary_response_blocking
    raise _InactiveRpcError(state)
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.DEADLINE_EXCEEDED
	details = "Deadline Exceeded"
	debug_error_string = "{"created":"@1588771706.167677943","description":"Error received from peer ipv4:108.177.112.95:443","file":"src/core/lib/surface/call.cc","file_line":1056,"grpc_message":"Deadline Exceeded","grpc_status":4}"
>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/backup_sample_test.py", line 97, in test_update_backup
backup_sample.update_backup(INSTANCE_ID, BACKUP_ID)
File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/backup_sample.py", line 232, in update_backup
backup.update_expire_time(new_expire_time)
File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/cloud/spanner_v1/backup.py", line 249, in update_expire_time
api.update_backup(backup_update, update_mask, metadata=metadata)
File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py", line 1192, in update_backup
return self._inner_api_calls["update_backup"](
File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/gapic_v1/method.py", line 143, in call
return wrapped_func(*args, **kwargs)
File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/retry.py", line 281, in retry_wrapped_func
return retry_target(
File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/retry.py", line 184, in retry_target
return target()
File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/timeout.py", line 214, in func_with_timeout
return func(*args, **kwargs)
File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/grpc_helpers.py", line 59, in error_remapped_callable
six.raise_from(exceptions.from_grpc_error(exc), exc)
File "", line 3, in raise_from
google.api_core.exceptions.DeadlineExceeded: 504 Deadline Exceeded

@tmatsuo
Copy link
Contributor

tmatsuo commented May 6, 2020

The last build failure is:

Traceback (most recent call last):
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/grpc_helpers.py", line 57, in error_remapped_callable
    return callable_(*args, **kwargs)
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/grpc/_channel.py", line 826, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/grpc/_channel.py", line 729, in _end_unary_response_blocking
    raise _InactiveRpcError(state)
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.DEADLINE_EXCEEDED
	details = "Deadline Exceeded"
	debug_error_string = "{"created":"@1588771706.167677943","description":"Error received from peer ipv4:108.177.112.95:443","file":"src/core/lib/surface/call.cc","file_line":1056,"grpc_message":"Deadline Exceeded","grpc_status":4}"
>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/backup_sample_test.py", line 97, in test_update_backup
    backup_sample.update_backup(INSTANCE_ID, BACKUP_ID)
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/backup_sample.py", line 232, in update_backup
    backup.update_expire_time(new_expire_time)
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/cloud/spanner_v1/backup.py", line 249, in update_expire_time
    api.update_backup(backup_update, update_mask, metadata=metadata)
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py", line 1192, in update_backup
    return self._inner_api_calls["update_backup"](
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/gapic_v1/method.py", line 143, in __call__
    return wrapped_func(*args, **kwargs)
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/retry.py", line 281, in retry_wrapped_func
    return retry_target(
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/retry.py", line 184, in retry_target
    return target()
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/timeout.py", line 214, in func_with_timeout
    return func(*args, **kwargs)
  File "/tmpfs/src/github/python-docs-samples/spanner/cloud-client/.nox/py-3-8/lib/python3.8/site-packages/google/api_core/grpc_helpers.py", line 59, in error_remapped_callable
    six.raise_from(exceptions.from_grpc_error(exc), exc)
  File "<string>", line 3, in raise_from
google.api_core.exceptions.DeadlineExceeded: 504 Deadline Exceeded

@tmatsuo
Copy link
Contributor

tmatsuo commented May 6, 2020

The current deadline is 30 seconds for UpdateBackup.

I'll talk with the Spanner folks to decide how to handle this case.

@tmatsuo
Copy link
Contributor

tmatsuo commented May 7, 2020

The spanner team is going to bump the deadline, so we don't have any action items other than wait for the next release.

@tmatsuo
Copy link
Contributor

tmatsuo commented May 27, 2020

Got the new release, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
6 participants