Talent v4beta1 samples [Restoring deleted branch samples] #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@kurtisvg please add DO_NOT_MERGE label. |
kurtisvg
added
the
do not merge
|
@tmatsuo Hey Takashi, I just added tests and formatting to these autogenerated python code. I do not have permission to modify anything in this PR. |
tmatsuo
removed
the
do not merge
tmatsuo
suggested changes
Apr 29, 2020
|
@munkhuushmgl - Could you please address the feedback on this PR? We have a fix it around trying to reduce open issues/PRs on this repo this week. |
@kurtisvg I will address the feedback EOD |
…mgl/python-docs-samples into talent-v4beta1-samples
…mgl/python-docs-samples into talent-v4beta1-samples
…mgl/python-docs-samples-1 into talent-v4beta1-samples
…mgl/python-docs-samples-1 into talent-v4beta1-samples
tmatsuo
reviewed
May 19, 2020
|
@tmatsuo Thanks for the feedback, I do not have permission to merge this, |
tmatsuo
approved these changes
May 21, 2020
busunkim96
pushed a commit
to busunkim96/python-talent
that referenced
this pull request
Sep 24, 2020
…oogleCloudPlatform/python-docs-samples#3273) * restored deleted samples * fixed lint issues * added tests and formatted code * corrected test req.txt file * made requested changes and added return val for samples * added secrets.txt to bash, script * fixed the lint * moved to requirements-test.txt * delete resources in teardown just in case * restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint * added some spacing * restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint moved to requirements-test.txt delete resources in teardown just in case added some spacing * fixed merge conflicts * added conftest.py and refactored samples with loop * removed talent secret.txt from bash script * fixed the lint issue * removed unnecessary env vars * deleted global random ids, deleted unnecessary setup code from delete tests * removed unused imports * removed pytest * removed unused IDs * deleted unused uuid imports Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
busunkim96
pushed a commit
to googleapis/python-talent
that referenced
this pull request
Sep 25, 2020
…oogleCloudPlatform/python-docs-samples#3273) * restored deleted samples * fixed lint issues * added tests and formatted code * corrected test req.txt file * made requested changes and added return val for samples * added secrets.txt to bash, script * fixed the lint * moved to requirements-test.txt * delete resources in teardown just in case * restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint * added some spacing * restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint moved to requirements-test.txt delete resources in teardown just in case added some spacing * fixed merge conflicts * added conftest.py and refactored samples with loop * removed talent secret.txt from bash script * fixed the lint issue * removed unnecessary env vars * deleted global random ids, deleted unnecessary setup code from delete tests * removed unused imports * removed pytest * removed unused IDs * deleted unused uuid imports Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
xtineskim
pushed a commit
that referenced
this pull request
Nov 11, 2022
…3273) * restored deleted samples * fixed lint issues * added tests and formatted code * corrected test req.txt file * made requested changes and added return val for samples * added secrets.txt to bash, script * fixed the lint * moved to requirements-test.txt * delete resources in teardown just in case * restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint * added some spacing * restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint moved to requirements-test.txt delete resources in teardown just in case added some spacing * fixed merge conflicts * added conftest.py and refactored samples with loop * removed talent secret.txt from bash script * fixed the lint issue * removed unnecessary env vars * deleted global random ids, deleted unnecessary setup code from delete tests * removed unused imports * removed pytest * removed unused IDs * deleted unused uuid imports Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
…3273) * restored deleted samples * fixed lint issues * added tests and formatted code * corrected test req.txt file * made requested changes and added return val for samples * added secrets.txt to bash, script * fixed the lint * moved to requirements-test.txt * delete resources in teardown just in case * restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint * added some spacing * restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint moved to requirements-test.txt delete resources in teardown just in case added some spacing * fixed merge conflicts * added conftest.py and refactored samples with loop * removed talent secret.txt from bash script * fixed the lint issue * removed unnecessary env vars * deleted global random ids, deleted unnecessary setup code from delete tests * removed unused imports * removed pytest * removed unused IDs * deleted unused uuid imports Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 4, 2023
…oogleCloudPlatform/python-docs-samples#3273) * restored deleted samples * fixed lint issues * added tests and formatted code * corrected test req.txt file * made requested changes and added return val for samples * added secrets.txt to bash, script * fixed the lint * moved to requirements-test.txt * delete resources in teardown just in case * restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint * added some spacing * restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint restored deleted samples fixed lint issues added tests and formatted code corrected test req.txt file made requested changes and added return val for samples added secrets.txt to bash, script fixed the lint moved to requirements-test.txt delete resources in teardown just in case added some spacing * fixed merge conflicts * added conftest.py and refactored samples with loop * removed talent secret.txt from bash script * fixed the lint issue * removed unnecessary env vars * deleted global random ids, deleted unnecessary setup code from delete tests * removed unused imports * removed pytest * removed unused IDs * deleted unused uuid imports Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.