Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerous warnings when building #33

Closed
1 of 4 tasks
wiw-evan-olcott opened this issue Feb 2, 2023 · 8 comments
Closed
1 of 4 tasks

Numerous warnings when building #33

wiw-evan-olcott opened this issue Feb 2, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@wiw-evan-olcott
Copy link

Describe the bug

When building an app with this Swift package installed, multiple warnings appear regarding missing paths when GenerateDSYMFile executes.

Integration Method

Select the method used to integrate with reCAPTCHA Mobile.

  • SPM (iOS)
  • Cocoapods (iOS)
  • Direct Download (iOS)
  • GMaven (Android)

SDK Version (e.g. 18.0.1): 18.0.3

To Reproduce

Steps to reproduce the behavior:

  1. Add the SPM to an Xcode project (preferably on a machine that has not been used for development of this package)
  2. Build
  3. Observe multiple warnings regarding missing paths
warning: /private/var/netboot/workspace/394528483693365d58e060dcb6d81b86ba17a82c3d5ea8f4c0ca86171eee43d6_01002a48/google3/blaze-out/ios-x86_64-min12.0-applebin_ios-ios_x86_64-opt-ST-c9c798c8be62/bin/third_party/apple_frameworks/WebKit.swift.pcm: No such file or directory
note: while processing /private/var/netboot/workspace/394528483693365d58e060dcb6d81b86ba17a82c3d5ea8f4c0ca86171eee43d6_01002a48/google3/blaze-out/ios-x86_64-min12.0-applebin_ios-ios_x86_64-opt-ST-c9c798c8be62/bin/third_party/apple_frameworks/WebKit.swift.pcm
note: Linking a static library that was built with -gmodules, but the module cache was not found.  Redistributable static libraries should never be built with module debugging enabled.  The debug experience will be degraded due to incomplete debug information.

The above is repeated many times with slightly different paths.

Expected behavior

No warnings should appear when building the project

Xcode version for iOS (please complete the following information):

  • Version [e.g. Xcode 13.4.1]: 14.2

Additional context

These paths causing the warnings are all prefixed with /private/var/netboot/workspace/..., and are hard-coded into the static library as found in the xcframework. These paths need to be stripped or removed when generating the static libraries for this package.

I believe this note in the warning contains the solution:

note: Linking a static library that was built with -gmodules, but the module cache was not found.  Redistributable static libraries should never be built with module debugging enabled.  The debug experience will be degraded due to incomplete debug information.
@wiw-evan-olcott wiw-evan-olcott added the bug Something isn't working label Feb 2, 2023
@mcorner
Copy link
Collaborator

mcorner commented Feb 2, 2023

We have seen these in the past and have determined that they are harmless.

To confirm though, these are all warnings and not errors?

@evan-olcott
Copy link

Yes, these are warnings, not errors. But it's just not good "framework etiquette" to add warnings to other projects - they're not harmless. They make it hard to find ACTUAL warnings if we have to work around the ones we can't control.

Our company doesn't ship builds to production with warnings, and I plead for someone to clean them up so we can implement reCaptcha in our app.

@mcorner
Copy link
Collaborator

mcorner commented Feb 3, 2023

Yep, I hear you and would like to fix it if possible. Someone looked at this two years ago and determined it was harmless. I believe it is related to the CLANG_ENABLE_MODULE_DEBUGGING=YES default, but ....I actually don't see this warning myself to reproduce it and fix. So I am guessing there is a difference in flags.

Do you have a minimal repro of the warning?

@mcorner
Copy link
Collaborator

mcorner commented Feb 3, 2023

Ah, got it. Happens on archive. We will look into it.

@wiw-evan-olcott
Copy link
Author

Excellent, and thanks!

@mcorner
Copy link
Collaborator

mcorner commented Feb 6, 2023

We believe that we have fixed this internally and should be able to include it in the next release of the SDK.

We will continue to test the internally in the meantime.

Thanks for the report.

@mcorner
Copy link
Collaborator

mcorner commented Mar 3, 2023

We haven't forgotten about this, we did fix it and it will be included in an iOS release that should occur very shortly.

@mcorner
Copy link
Collaborator

mcorner commented Mar 16, 2023

This has been addressed in 18.1.1 released yesterday (no release notes yet)

@mcorner mcorner closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants