Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output tag name and upload url #43

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

mmarchini
Copy link
Contributor

The tag name is useful to interact with the release on following steps,
and the upload url is useful to upload assets to the release.

Fix: #8
Fix: #41

The tag name is useful to interact with the release on following steps,
and the upload url is useful to upload assets to the release.

Fix: googleapis#8
Fix: googleapis#41
@bcoe bcoe merged commit 90469b0 into googleapis:main Jul 23, 2020
@bcoe
Copy link
Contributor

bcoe commented Jul 23, 2020

@mmarchini thank you for the contribution 👌

@bcoe
Copy link
Contributor

bcoe commented Jul 23, 2020

@mmarchini tagged release@1.4.0

@jef
Copy link
Contributor

jef commented Jul 23, 2020

what does tag_name and upload_url look like? we can update some doc around the change. thanks for putting this out!

@mmarchini
Copy link
Contributor Author

Both are equal to their respective values in the Create Release API response. The tag_name is the tag name (not to be mistaken with the release name), and the upload_url is an URL to the upload asset API endpoint. Agreed we should add some documentation, maybe an extra section in the readme with all values set in the output of the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: create output for version Call @actions/core setOutput with created tag
3 participants