Storage Bucket environment variable name not consistent

[frankyn]

Story

Trying to run RSPEC on samples which use a bucket id isn't straight forward. It always documented either. It's hidden in the SPEC.

Issue
No consistent ENV name was used. A quick grep reveals the following.

bigquery/spec/bigquery_sample_spec.rb:
appengine/storage/app.rb:bucket = storage.bucket ENV["GCLOUD_STORAGE_BUCKET"]
appengine/storage/README.md:export GCLOUD_STORAGE_BUCKET=
appengine/storage/spec/storage_spec.rb: .sub("", ENV["GCLOUD_STORAGE_BUCKET"])
appengine/storage/app.yaml: GCLOUD_STORAGE_BUCKET:
language/spec/language_samples_spec.rb: @bucket_name = ENV["STORAGE_BUCKET"]
logging/spec/sample_spec.rb: # BUCKET Name of Google Cloud Storage bucket to use for log sink
logging/spec/sample_spec.rb: # ALT_BUCKET Name of an alternative bucket to also use for log sink
logging/spec/sample_spec.rb: @bucket = @storage.bucket ENV["BUCKET"]
logging/spec/sample_spec.rb: @alt_bucket = @storage.bucket ENV["ALT_BUCKET"]
storage/spec/list_buckets_spec.rb: output(/#{BUCKET_NAME}/).to_stdout)
storage/spec/spec_helper.rb:BUCKET_NAME=ENV["GOOGLE_PROJECT_ID"]

Possible-Solution

Use a consistent name , maybe, GOOGLE_STORAGE_BUCKET_ID ?

[frankyn]

Resolved.