Metrics module enhancements #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
meltsufin
commented
Nov 13, 2020
•
meltsufin
commented
- Updates metrics sample to fix documentation and make it easier to use
- Moves actuator starter into our metrics starter and updates corresponding section in refdoc
- Adds a link to the metrics sample in the refdoc
- Adds header provider to enable usage metrics for the module
elefeint
approved these changes
Nov 13, 2020
| @ConditionalOnBean(Clock.class) | ||
| @ConditionalOnEnabledMetricsExport("stackdriver") | ||
| @EnableConfigurationProperties({GcpMetricsProperties.class, StackdriverProperties.class}) | ||
| @ConditionalOnProperty(value = "spring.cloud.gcp.metrics.enabled", matchIfMissing = true, havingValue = "true") |
There was a problem hiding this comment.
Do we need both this and @ConditionalOnEnabledMetricsExport?
There was a problem hiding this comment.
They use different properties to disable the module. One way is through actuator and one through our standard spring.cloud.gpc.metrics.enabled.
dzou
approved these changes
Nov 13, 2020
ttomsu
force-pushed
the
metrics-enhancements
branch
from
2cb2425
to
807132f
Compare
ttomsu
approved these changes
Nov 16, 2020
meltsufin
added a commit
to spring-attic/spring-cloud-gcp
that referenced
this pull request
Nov 16, 2020
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.