switch to commit to avoid write limitations #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # spring-cloud-gcp-data-firestore/src/main/java/com/google/cloud/spring/data/firestore/FirestoreTemplate.java
ttomsu
approved these changes
Nov 19, 2020
elefeint
suggested changes
Nov 19, 2020
| return ObservableReactiveUtil.streamingBidirectionalCall( | ||
| this::openWriteStream, inputs, this::buildWriteRequest); | ||
| return Flux.from(instances).bufferTimeout(this.writeBufferSize, this.writeBufferTimeout) | ||
| .flatMap(ts -> { |
There was a problem hiding this comment.
I keep reading it as "timestamp". Rename to something more meaningful?
| documentNames.bufferTimeout(this.writeBufferSize, this.writeBufferTimeout), | ||
| this::buildDeleteRequest); | ||
| return Flux.from(documentNames).bufferTimeout(this.writeBufferSize, this.writeBufferTimeout) | ||
| .flatMap(ts -> { |
There was a problem hiding this comment.
Same, rename ts to something -- it also turns into e for Entity later in this block, so maybe something more consistent like "entity".
| @@ -221,8 +222,8 @@ public void saveAllTest() { | |||
| @Test | |||
| public void saveAllBulkTest() { | |||
| Flux<User> users = Flux.create(sink -> { | |||
| for (int i = 0; i < 1000; i++) { | |||
| sink.next(new User("testUser " + i, i)); | |||
| for (int i = 0; i < 10000; i++) { | |||
There was a problem hiding this comment.
We can probably keep it at 1,000. 10K was useful for weeding out flakes, but likely not necessary for a regularly run test.
…gcp into firestore-write-commit
…rm/spring-cloud-gcp into firestore-write-commit
meltsufin
approved these changes
Nov 19, 2020
elefeint
approved these changes
Nov 19, 2020
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #126