Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove SecretManagerPropertySourceLocator #1571

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Feb 3, 2023

Fix #1570

@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JoeWang1127 JoeWang1127 marked this pull request as ready for review February 4, 2023 19:34
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a public class, and there might be usage outside of the

@JoeWang1127
Copy link
Contributor Author

Since it's a public class, and there might be usage outside of the

Should we deprecate the class and remove it in the next major version?

@meltsufin
Copy link
Member

Since it's a public class, and there might be usage outside of the

Should we deprecate the class and remove it in the next major version?

Oops, I didn't mean to send that. I started writing that and then changed my mind after looking more into the use of the class exclusively for bootstrap. We are still keeping the actual PropertySource. So, I think it's fine to remove.

@JoeWang1127
Copy link
Contributor Author

Cool, then I'll proceed with the merge.

@JoeWang1127 JoeWang1127 merged commit c80d299 into main Feb 6, 2023
@JoeWang1127 JoeWang1127 deleted the feature/remove-secretmanager-property-locator branch February 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SecretManagerPropertySourceLocator as it is not needed
2 participants