Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provide setters for min/max duration per ack ext #1644

Merged
merged 6 commits into from
Mar 6, 2023
Merged

fix: provide setters for min/max duration per ack ext #1644

merged 6 commits into from
Mar 6, 2023

Conversation

meltsufin
Copy link
Member

Fixes: #1643.

@JoeWang1127
Copy link
Contributor

Do you think we should add some unit tests?

@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@meltsufin meltsufin enabled auto-merge (squash) March 6, 2023 16:21
@meltsufin meltsufin merged commit cd3a75c into main Mar 6, 2023
@meltsufin meltsufin deleted the setters-for-ack-extension branch March 6, 2023 16:24
@release-please release-please bot mentioned this pull request Mar 6, 2023
Merged
@release-please release-please bot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes

Assignees
No one assigned
Labels
pubsub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DefaultSubscriberFactory is lacking minDurationPerAckExtension and maxDurationPerAckExtension setter
2 participants
@meltsufin @JoeWang1127