fix: regression of outbound pubsub message handling (success/failure callbacks both called regardless of success/failure)

[nathanpiper]

Fix #1799.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[meltsufin]

@nathanpiper Thanks for the fix. Can you please sign the CLA?

[meltsufin]

LGTM, @JoeWang1127 Can you take a look as well?

[nathanpiper]

Thanks for reviewing. I just realised my commits have the wrong email address. What’s the best way to fix this? Should I just close this PR, create a new one and reference this one?

[JoeWang1127]

I think you can change the email in the commits.

[nathanpiper]

Thanks, I have updated it now and signed the CLA.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication