fix: pull-endpoint setting for async subscribers #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
commented
May 21, 2023
| subscriberStubSettings.setEndpoint(this.pullEndpoint); | ||
| } else { | ||
| applyGlobalPullEndpoint(subscriberStubSettings); | ||
| String endpoint = |
There was a problem hiding this comment.
Unrelated change for consistency sake, removing the need for applyGlobalPullEndpoint().
mpeddada1
reviewed
May 22, 2023
Comment on lines
+387
to
+388
| .hasFieldOrPropertyWithValue("numPullers", 2) | ||
| .hasFieldOrPropertyWithValue("subStubSettings.endpoint", "test.endpoint"); |
There was a problem hiding this comment.
It may also be worth covering this in our integration tests?
There was a problem hiding this comment.
Added and also found some unrelated bug accidentally.
|
Kudos, SonarCloud Quality Gate passed! |
mpeddada1
reviewed
May 23, 2023
| @@ -184,7 +184,7 @@ public FlowControl computeSubscriberFlowControlSettings(ProjectSubscriptionName | |||
| */ | |||
| public Integer computeParallelPullCount(String subscriptionName, String projectId) { | |||
| Integer parallelPullCount = | |||
| getSubscriptionProperties(ProjectSubscriptionName.of(projectId, subscriptionName)) | |||
| getSubscriptionProperties(PubSubSubscriptionUtils.toProjectSubscriptionName(subscriptionName, projectId)) | |||
mpeddada1
approved these changes
May 23, 2023
meltsufin
added a commit
that referenced
this pull request
May 23, 2023
* fix: pull-endpoint setting for async subscribers * add integration test and fix fqn subscription usage Fixes: #1882.
meltsufin
added a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1882.