Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure proper merging of Binder default props #2177

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: Ensure proper merging of Binder default props #2177

merged 1 commit into from
Sep 18, 2023

Conversation

meltsufin
Copy link
Member

Fixes #2151.

@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@meltsufin
Copy link
Member Author

I manually tested it to make sure it works, but I can't find a straightforward way to test this automatically.

@meltsufin meltsufin marked this pull request as ready for review September 18, 2023 17:31
@meltsufin meltsufin requested a review from a team as a code owner September 18, 2023 17:31
@meltsufin meltsufin enabled auto-merge (squash) September 18, 2023 18:57
JoeWang1127
JoeWang1127 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@JoeWang1127 JoeWang1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meltsufin meltsufin merged commit 01b3dad into main Sep 18, 2023
30 checks passed
@meltsufin meltsufin deleted the pubsub-binder-defaults-merge branch September 18, 2023 19:22
@release-please release-please bot mentioned this pull request Sep 18, 2023
Merged
meltsufin added a commit that referenced this pull request Sep 19, 2023
@meltsufin
fix: Ensure proper merging of Binder default props (#2177)
9c7e56f 
Fixes #2151.
@meltsufin meltsufin mentioned this pull request Sep 19, 2023
Merged
meltsufin added a commit that referenced this pull request Sep 19, 2023
@meltsufin
fix(3.x): Ensure proper merging of Binder default props #2179)
27150e7 
Backport of #2177.

Fixes #2151.
@release-please release-please bot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes

Assignees
No one assigned
Labels
pubsub
Projects
None yet
Milestone
No milestone
2 participants
@meltsufin @JoeWang1127