Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Spring Cloud 2023 and Spring Boot 3.2.0 #2438

Merged
merged 8 commits into from
Dec 13, 2023

Conversation

burkedavison
Copy link
Member

No description provided.

@burkedavison burkedavison requested a review from a team as a code owner December 12, 2023 18:44
@burkedavison burkedavison changed the title BREAKING CHANGE: Spring Cloud 2023 and Spring Boot 3.2.0 feat!: Spring Cloud 2023 and Spring Boot 3.2.0 Dec 12, 2023
@burkedavison burkedavison marked this pull request as draft December 12, 2023 18:56
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@burkedavison burkedavison marked this pull request as ready for review December 13, 2023 16:46
Comment on lines -94 to -95
assertThat(context.getBeansOfType(ObservedAspect.class)).isEmpty();
});
Copy link
Contributor

@mpeddada1 mpeddada1 Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Note for future reference] As discussed offline, this class is provided by Spring by default (https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.2.0-M1-Release-Notes#observability-improvements)

@burkedavison burkedavison merged commit ee4a9d6 into main Dec 13, 2023
50 of 51 checks passed
@burkedavison burkedavison deleted the spring-cloud-2023-update branch December 13, 2023 16:55
This was referenced Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants