Allow specifying a custom subscription as a consumer endpoint #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
requested changes
Feb 5, 2021
...n/java/com/google/cloud/spring/stream/binder/pubsub/properties/PubSubConsumerProperties.java
Outdated
Show resolved
Hide resolved
...java/com/google/cloud/spring/stream/binder/pubsub/provisioning/PubSubChannelProvisioner.java
Outdated
Show resolved
Hide resolved
elefeint
previously requested changes
Feb 5, 2021
...java/com/google/cloud/spring/stream/binder/pubsub/provisioning/PubSubChannelProvisioner.java
Show resolved
Hide resolved
...java/com/google/cloud/spring/stream/binder/pubsub/provisioning/PubSubChannelProvisioner.java
Outdated
Show resolved
Hide resolved
...java/com/google/cloud/spring/stream/binder/pubsub/provisioning/PubSubChannelProvisioner.java
Outdated
Show resolved
Hide resolved
...com/google/cloud/spring/stream/binder/pubsub/provisioning/PubSubChannelProvisionerTests.java
Show resolved
Hide resolved
|
@elefeint I think we were reviewing in parallel :) |
|
Yup. I went through my mailbox in reverse chronological order, and you moved in chronological order, and @ttomsu PR is where the two workflows intersected. |
ttomsu
force-pushed
the
custom-subscription
branch
from
68106ef
to
c306630
Compare
meltsufin
requested changes
Feb 19, 2021
| @@ -75,13 +75,24 @@ spring.cloud.stream.gcp.pubsub.bindings.{CONSUMER_NAME}.consumer.ack-mode=AUTO_A | |||
| If automatic resource creation is turned ON and the subscription and/or the topic do not exist for a consumer, a subscription and potentially a topic will be created. | |||
| The topic name will be the same as the destination name, and the subscription name will be the destination name followed by the consumer group name. | |||
|
|
|||
| Regardless of the `auto-create-resources` setting, if the consumer group is not specified, an anonymous one will be created with the name `anonymous.<destinationName>.<randomUUID>`. | |||
| Regardless of the `auto-create-resources` setting, you can control the subscriber with the following options (in order of precedence): | |||
There was a problem hiding this comment.
Suggested change
| Regardless of the `auto-create-resources` setting, you can control the subscriber with the following options (in order of precedence): | |
| Regardless of the `auto-create-resources` setting, the subscription name will be determined as follows (in order of precedence): |
There was a problem hiding this comment.
Ended up removing this text block
| Regardless of the `auto-create-resources` setting, if the consumer group is not specified, an anonymous one will be created with the name `anonymous.<destinationName>.<randomUUID>`. | ||
| Regardless of the `auto-create-resources` setting, you can control the subscriber with the following options (in order of precedence): | ||
|
|
||
| * A pre-existing subscription (use `spring.cloud.stream.gcp.pubsub.bindings.{CONSUMER_NAME}.consumer.subscriptionName`) |
There was a problem hiding this comment.
Suggested change
| * A pre-existing subscription (use `spring.cloud.stream.gcp.pubsub.bindings.{CONSUMER_NAME}.consumer.subscriptionName`) | |
| * If specified, `spring.cloud.stream.gcp.pubsub.bindings.{CONSUMER_NAME}.consumer.subscriptionName` property |
There was a problem hiding this comment.
With the "in order of precedence" above, I don't think it's necessary to have to say "if specified"
| Regardless of the `auto-create-resources` setting, you can control the subscriber with the following options (in order of precedence): | ||
|
|
||
| * A pre-existing subscription (use `spring.cloud.stream.gcp.pubsub.bindings.{CONSUMER_NAME}.consumer.subscriptionName`) | ||
| * A consumer group that uses the topic name (use `spring.cloud.stream.bindings.events.group` to create a subscription named `<topicName>.<group>`) |
There was a problem hiding this comment.
Suggested change
| * A consumer group that uses the topic name (use `spring.cloud.stream.bindings.events.group` to create a subscription named `<topicName>.<group>`) | |
| * If specified, `spring.cloud.stream.bindings.events.group` property that results in a subscription named `<topicName>.<group>` |
| @@ -75,13 +75,24 @@ spring.cloud.stream.gcp.pubsub.bindings.{CONSUMER_NAME}.consumer.ack-mode=AUTO_A | |||
| If automatic resource creation is turned ON and the subscription and/or the topic do not exist for a consumer, a subscription and potentially a topic will be created. | |||
There was a problem hiding this comment.
I think we should add a note here that, only anonymous subscriptions will be cleaned up.
There was a problem hiding this comment.
It's mentioned twice below this.
meltsufin
approved these changes
Feb 19, 2021
|
Kudos, SonarCloud Quality Gate passed! |
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
…CloudPlatform#262) * Allow specifying a custom subscription as a consumer endpoint
prash-mi
pushed a commit
that referenced
this pull request
Jun 20, 2023
Introduce a parallel implementation of the driver based on the client library, with the goal of providing consistent behavior for JDBC and R2DBC Cloud Spanner drivers.
For now, gRPC implementation remains primary; switching to the client library implementation requires providing .option(Option.valueOf("client-implementation"), "client-library") when creating a connection factory.
Query with parameter binding
DML with transactions
DDL temporarily falls back on gRPC implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181