Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update cloud-sql-socket-factory.version to v1.16.0 #2643

Conversation

ttosta-google
Copy link
Contributor

In order to use the new version 1.16.0 it's required to use the new method to set artifact ID.

Related to #2503

@ttosta-google ttosta-google requested a review from a team as a code owner February 27, 2024 19:23
Copy link

sonarcloud bot commented Feb 27, 2024

@ttosta-google
Copy link
Contributor Author

ttosta-google commented Feb 27, 2024

@mpeddada1 There are 4 open PRs to update cloud-sql-socket-factory to the latest version. They are all failing. My PR fixes the issue. Could you please review it? Thanks!

#2350
#2600
#2601
#2602

@enocom
Copy link
Member

enocom commented Feb 28, 2024

@meltsufin Does your team bump this dependency with automation? We release a new version every month and it would be nice to keep it up to date here.

@meltsufin
Copy link
Member

@enocom Yes, it should be regularly updated by renovate/dependabot. It hasn't been updated for a while because the pending PR was blocked on CI failures. We should be OK going forward though

@meltsufin meltsufin merged commit 67d54f0 into GoogleCloudPlatform:main Feb 28, 2024
11 checks passed
@enocom
Copy link
Member

enocom commented Feb 28, 2024

Sounds good. In making some internal refactors we meant to proactively update this usage here immediately, but lost track of that detail.

In the future, if you see any problems with this dep, let us know and we'll happily fix it ASAP.

@ttosta-google ttosta-google deleted the update-cloud-sql-socket-factory-version branch February 28, 2024 17:02
zhumin8 pushed a commit that referenced this pull request Mar 7, 2024
* fix(deps): update cloud-sql-socket-factory.version to v1.16.0

* chore: remove unused import
zhumin8 pushed a commit that referenced this pull request Mar 7, 2024
* fix(deps): update cloud-sql-socket-factory.version to v1.16.0

* chore: remove unused import
lqiu96 added a commit that referenced this pull request May 1, 2024
…#2656)

* fix(deps): update cloud-sql-socket-factory.version to v1.16.0

* chore: remove unused import

Co-authored-by: Tatiane Tosta <91583351+ttosta-google@users.noreply.github.com>
Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
lqiu96 added a commit that referenced this pull request May 1, 2024
…#2655)

* fix(deps): update cloud-sql-socket-factory.version to v1.16.0

* chore: remove unused import

Co-authored-by: Tatiane Tosta <91583351+ttosta-google@users.noreply.github.com>
Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants