docs: Memorystore documentation improvements #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breun
force-pushed
the
memorystore-documentation-improvements
branch
from
23b8d3e
to
f43c84d
Compare
zhumin8
requested changes
Apr 13, 2024
There was a problem hiding this comment.
Thank you for taking the time to update our documentation!
And sorry for the delay in review process.
I've tested out and this looks great in general, only got a few comments below.
btw, I see the linked codelab also has outdated configurations, I will update those.
…store-documentation-improvements
Co-authored-by: Min Zhu <zhumin@google.com>
|
@zhumin8 Thanks for your suggestions, I've applied them all. |
zhumin8
requested changes
Apr 17, 2024
Co-authored-by: Min Zhu <zhumin@google.com>
|
No problem, I've committed your suggested changes. |
zhumin8
changed the title
zhumin8
changed the title
|
zhumin8
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains Memorystore documentation improvements as described in #2735.