feat: add build service account argument #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apeabody Can you please trigger CI tests for this? It helps address 1269 in the foundation repo |
|
/gcbrun |
|
Just fixed the variable description, might need the integration build to be triggered again @apeabody |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are environments in which neither the Cloud Build Service Account nor the Compute Engine Service Account can be used, in these cases the user would need to specify a custom service account for running the builds. Currently the module does not support this argument. This PR adds the fields necessary to externalize the build service account argument.
References:
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/cloudfunctions2_function#nested_build_config
#129
terraform-google-modules/terraform-example-foundation#1269