Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds secure cloud-function-core sub-module #20

Conversation

amandakarina
Copy link
Collaborator

Hey folks

This PR adds the initial version of sub-module for secure-cloud-functions, following the security best practices.

Could you, please, take a look on it?

Thanks!

@amandakarina amandakarina requested review from a team and prabhu34 as code owners April 3, 2023 18:00
@amandakarina
Copy link
Collaborator Author

/gcbrun

@amandakarina amandakarina changed the title Adds secure cloud function sub-module feat:adds secure cloud function sub-module Apr 3, 2023
@amandakarina amandakarina changed the title feat:adds secure cloud function sub-module feat: adds secure cloud function sub-module Apr 3, 2023
@amandakarina amandakarina force-pushed the feat/adds-secure-cloud-function-core-module branch from 5abbbaa to 68330a5 Compare April 3, 2023 18:14
@amandakarina
Copy link
Collaborator Author

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.

modules/secure-cloud-function-core/versions.tf Outdated Show resolved Hide resolved
modules/secure-cloud-function-core/versions.tf Outdated Show resolved Hide resolved
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
@amandakarina
Copy link
Collaborator Author

Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.

Hey @apeabody

Can we follow the standard used in secure-cloud-run?

An standalone example and the secure-cloud-function example? Those examples use the composition module (to be done) to be tested.

@apeabody
Copy link
Contributor

apeabody commented Apr 6, 2023

Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.

Hey @apeabody

Can we follow the standard used in secure-cloud-run?

An standalone example and the secure-cloud-function example? Those examples use the composition module (to be done) to be tested.

Sure, sounds good to me!

Copy link
Collaborator

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Provided a few comments

modules/secure-cloud-function-core/main.tf Outdated Show resolved Hide resolved
modules/secure-cloud-function-core/README.md Outdated Show resolved Hide resolved
modules/secure-cloud-function-core/main.tf Outdated Show resolved Hide resolved
modules/secure-cloud-function-core/variables.tf Outdated Show resolved Hide resolved
modules/secure-cloud-function-core/versions.tf Outdated Show resolved Hide resolved
modules/secure-cloud-function-core/variables.tf Outdated Show resolved Hide resolved
modules/secure-cloud-function-core/main.tf Show resolved Hide resolved
Copy link
Collaborator

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small changes, then LGTM, thanks!

@amandakarina amandakarina changed the title feat: adds secure cloud function sub-module feat: adds secure cloud-function-core sub-module Apr 24, 2023
@gtsorbo gtsorbo merged commit c9c197f into GoogleCloudPlatform:main Apr 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants