-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds secure cloud-function-core sub-module #20
feat: adds secure cloud-function-core sub-module #20
Conversation
/gcbrun |
5abbbaa
to
68330a5
Compare
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Hey @apeabody Can we follow the standard used in secure-cloud-run? An standalone example and the secure-cloud-function example? Those examples use the composition module (to be done) to be tested. |
Sure, sounds good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Provided a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small changes, then LGTM, thanks!
Hey folks
This PR adds the initial version of sub-module for secure-cloud-functions, following the security best practices.
Could you, please, take a look on it?
Thanks!