feat: adds first version of secure-serverless-security module #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandakarina
force-pushed
the
feat/adds-secure-cloud-function-security-module
branch
from
841b956
to
8d2893d
Compare
|
/gcbrun |
apeabody
reviewed
Apr 5, 2023
There was a problem hiding this comment.
Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Hey @apeabody Can we follow the standard used in secure-cloud-run? An standalone example and the secure-cloud-function example? Those examples use the composition module (to be done) to be tested. |
gtsorbo
requested changes
Apr 6, 2023
gtsorbo
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks,
This PR adds the first version of the sub-module secure-serverless-security.
Could you, please, take a look on it?
Thanks!