Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds secure-cloud-function sub-module #22

Conversation

amandakarina
Copy link
Collaborator

@amandakarina amandakarina commented Apr 17, 2023

Hey folks,

This PR creates the sub-module secure-cloud-function.

Thanks!

@amandakarina amandakarina changed the title Adds secure-cloud-function sub-module enhancement: adds secure-cloud-function sub-module Apr 17, 2023
@amandakarina amandakarina force-pushed the feat/adds-secure-cloud-function-module branch from 75c185d to 67dc966 Compare April 18, 2023 12:48
@amandakarina amandakarina force-pushed the feat/adds-secure-cloud-function-module branch from 67dc966 to 4051980 Compare April 18, 2023 15:03
@amandakarina amandakarina changed the title enhancement: adds secure-cloud-function sub-module feat: adds secure-cloud-function sub-module Apr 20, 2023
@amandakarina amandakarina force-pushed the feat/adds-secure-cloud-function-module branch from 55a5b44 to 7a28120 Compare April 20, 2023 10:35
@amandakarina amandakarina force-pushed the feat/adds-secure-cloud-function-module branch 2 times, most recently from 439b0ac to 057df60 Compare April 26, 2023 12:49
@amandakarina amandakarina marked this pull request as ready for review April 26, 2023 13:35
@amandakarina amandakarina requested review from a team, prabhu34 and gtsorbo as code owners April 26, 2023 13:35
Copy link
Collaborator

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes then LGTM

modules/secure-cloud-function/versions.tf Outdated Show resolved Hide resolved
@gtsorbo gtsorbo merged commit 048efa0 into GoogleCloudPlatform:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants