fix: Change Secure Web Proxy creation to use terraform resource instead of gcloud command #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
3 similar comments
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
4 similar comments
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
amandakarina
changed the title
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
amandakarina
requested changes
Jul 24, 2023
amandakarina
requested changes
Jul 24, 2023
amandakarina
force-pushed
the
feat/using-swp-resource
branch
5 times, most recently
from
2407696
to
ee644c1
Compare
…eation, changes projects names to avoid conflict
amandakarina
force-pushed
the
feat/using-swp-resource
branch
from
ee644c1
to
fa0f75b
Compare
|
/gcbrun |
gtsorbo
approved these changes
Jul 27, 2023
amandakarina
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks.
This PR is to change the gcloud commands on SWP creation for the new terraform resource.
depends on GoogleCloudPlatform/terraform-google-cloud-run#137 + new release