Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env vars as a map #197

Closed
bharathkkb opened this issue May 7, 2024 · 3 comments
Closed

Env vars as a map #197

bharathkkb opened this issue May 7, 2024 · 3 comments
Labels

Comments

@bharathkkb
Copy link
Member

Support providing env vars as map(string) of k/v rather than list of objects. @prabhu34 any concerns with this for a future breaking change?

@prabhu34
Copy link
Collaborator

prabhu34 commented May 8, 2024

Hi @bharathkkb,

Environment variable can be of any type as in the below screenshot. Here map(string) or list(objects) cannot be the right types, as the values can be string, list or map.

If we are restricting to only string then it is good to go and use map(string) instead of list(objects). It wont break the existing application as the key name is considered as the indexed.

To include other types, I tried using any type of variable, but I am skeptical about the encoding being done for string env variable as well.

Screenshot Env Variables

@bharathkkb
Copy link
Member Author

Copy link

github-actions bot commented Jul 7, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jul 7, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants