Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update variables.tf to correct minor typos #20

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

kumar-dhanagopal
Copy link
Member

@kumar-dhanagopal kumar-dhanagopal commented Jan 11, 2023

Fixed minor typos in variables.tf

Fixed minor typos
@kumar-dhanagopal kumar-dhanagopal requested review from a team and tpryan as code owners January 11, 2023 01:43
@kumar-dhanagopal kumar-dhanagopal changed the title Update variables.tf Update variables.tf to fix minor typos Jan 11, 2023
@kumar-dhanagopal kumar-dhanagopal changed the title Update variables.tf to fix minor typos fix: Update variables.tf to correct minor typos Jan 11, 2023
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @kumar-dhanagopal!

Can you please also run make docker_generate_docs to update the README with the corrected descriptions. Thanks!

Copy link
Collaborator

@tpryan tpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumar-dhanagopal
Copy link
Member Author

@apeabody - I ran make docker_generate_docs as you requested. Besides the README.md file in the root directory, one other file was updated: examples/simple_example/README.md Please review.

@apeabody
Copy link
Contributor

@apeabody - I ran make docker_generate_docs as you requested. Besides the README.md file in the root directory, one other file was updated: examples/simple_example/README.md Please review.

Thanks @kumar-dhanagopal! Looks like that second file had a stale value which also needed to be updated.

@apeabody apeabody merged commit 2e9463e into GoogleCloudPlatform:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants