Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Test 2 nodes instead of 3 #78

Merged
merged 2 commits into from
Feb 28, 2024
Merged

feat: Test 2 nodes instead of 3 #78

merged 2 commits into from
Feb 28, 2024

Conversation

NimJay
Copy link
Contributor

@NimJay NimJay commented Feb 27, 2024 •
edited
Loading

@NimJay NimJay requested review from tpryan and a team as code owners February 27, 2024 13:56
@NimJay
Copy link
Contributor Author

NimJay commented Feb 28, 2024

Thanks, Drew, for the quick review/approval!

Merging is technically still blocked since we're not CODEOWNERS.
But we can override that as repo admins — I will do that. (My guess = @tpryan is okay with that. 😄 )
We should look at the CODEOWNERS files inside all JSS GitHub repos and correct them. I've opened Google-internal bug, b/327473818.

@NimJay NimJay merged commit f561d65 into main Feb 28, 2024
6 checks passed
@NimJay NimJay deleted the nimjay-nodes branch February 28, 2024 21:07
@release-please release-please bot mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrown arbrown arbrown approved these changes

@tpryan tpryan Awaiting requested review from tpryan tpryan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NimJay @arbrown