New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the official version for SDK-FB-prophet-online-forecasting-notebook #317
Adding the official version for SDK-FB-prophet-online-forecasting-notebook #317
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/gcbrun |
/gcbrun |
/gcbrun |
I saw a failure installing |
It must be the build related error messages while installing the fbprophet library. Those messages while installation seem common while installing fbprophet according to : facebook/prophet#1598 but ultimately the library gets installed. |
@sudarshan-SpringML Please fix PR title. It's not clear if it's a small edit or a whole new notebook from the title. |
@krishr2d2 The installation seemed to never finish after 17 hours. This is one of those cases where you'll have to dig a bit into why pip is behaving this way. I recommend using Vertex Workbench with a custom container to debug: The image you should use is gcr.io/cloud-devrel-public-resources/python-samples-testing-docker:latest |
…to overcome the errors during fbprophet installation
…to overcome the errors during fbprophet installation
@ivanmkc Are there any additional steps to get the instance started?? I tried creating the instance using the provided image but it doesn't allow me to access the JupyterLab on it. Alternatively, I've tested separating out the steps that install the fb-propphet's dependencies and the fb-prophet library without any installation errors on the user-managed instances but unable to run the linter test successfully on the changes. The linter test gave the following two errors :
These seem like coming from the linter test script rather than the the notebook. |
The linter test related errors are gone after re-installing the requirements for linter test. |
…/sudarshan-SpringML/vertex-ai-samples into sdk_fbprophet_forecasting_online
@ivanmkc gcbrun was 16 days ago, but still running? |
@ivanmkc , Is there a way to access the executed notebook for this PR. I can't find it currently as the logs are truncated. Also, the docker builds are replaced by gcloud build commands. Still, I suspect that the container building process is taking a lot of time in this case ultimately leading to a TIMEOUT. |
…ucture as per the template
ValueError Traceback (most recent call last) |
…ebook (GoogleCloudPlatform#317) Checklist for moving the notebook to the main repo: - [x] Use the [notebook template](https://togithub.com/GoogleCloudPlatform/vertex-ai-samples/blob/main/notebooks/notebook_template.ipynb) as a starting point. - [x] Follow the style and grammar rules outlined in the above notebook template. - [x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes. - [x] Passes all the required automated checks. You can locally test for formatting and linting with these [instructions](https://togithub.com/GoogleCloudPlatform/vertex-ai-samples/blob/main/docs/contributing.md#code-quality-checks). - [ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it. - [x] This notebook has been added to the [CODEOWNERS](https://togithub.com/GoogleCloudPlatform/vertex-ai-samples/blob/main/docs/CODEOWNERS) file under `# Official Notebooks` section, pointing to the author or the author's team. - [x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.
Checklist for moving the notebook to the main repo:
# Official Notebooks
section, pointing to the author or the author's team.