Create explore_data_in_bigquery_with_workbench.ipynb #885
Conversation
Adding in notebook for exploratory data analysis as part of "Data to AI" effort. See this Colab for what this notebook looks like after it is run: https://colab.research.google.com/drive/1JeNeMtj2A_5P5vo9wxSkrwHQM5JQSoAu. Submitting it with outputs shown since a lot of this about interactive visualization, which can inspire folks to use/read the notebook beyond just the code.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Adding owner for forthcoming exploratory data analysis notebook
|
View / edit / reply to this conversation on ReviewNB ivanmkc commented on 2022-08-24T23:19:39Z Line #2. def bq_query(sql, show_job_id=False): Consider using a verb for your method name, like: This is subjective but see https://softwareengineering.stackexchange.com/a/334196 for a discussion.
alokpattani commented on 2022-08-24T23:41:51Z Acknowledged. Leaving it this time (for consistency - this naming has been used in other notebooks that may get published) but can consider for future functions. |
|
View / edit / reply to this conversation on ReviewNB ivanmkc commented on 2022-08-24T23:19:40Z Please clean up all relevant BQ resources. alokpattani commented on 2022-08-24T23:31:48Z So there actually aren't any BQ resources to clean up since we use a public dataset and don't create any views, tables, models, etc. It's basically just different queries pulling data into notebooks and displaying as tables and charts in here, with outputs to Cloud Storage. |
|
So there actually aren't any BQ resources to clean up since we use a public dataset and don't create any views, tables, models, etc. It's basically just different queries pulling data into notebooks and displaying as tables and charts in here, with outputs to Cloud Storage. View entire conversation on ReviewNB |
|
Acknowledged. Leaving it this time (for consistency - this naming has been used in other notebooks that may get published) but can consider for future functions. View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB aarondietz234 commented on 2022-08-25T04:07:16Z In the Overview:
Nit: This is really picky but I don't like to describe the audience as a target--can we replace "targeted toward" with "written for"?
#######
In the Objective section, in the list of Google Cloud data analytics and ML services:
I'd add Vertex AI, separate from Vertex AI Workbench. They are two different APIs/services, and only Workbench is optional, if I understand this tutorial correctly.
#######
In the Costs section, I'd either remove "(optional)" from Vertex AI (because we still use the SDK even if we don't use Vertex AI Workbench), or split them out again, like in the Objective section:
#######
If you make the previous suggested change, consider making the pricing info more clear, by changing "Vertex AI pricing" to "Vertex AI and Vertex AI Workbench pricing". Not sure what's clearer, really, but it may help them understand that Vertex AI and Vertex AI Workbench pricing are on the same page. alokpattani commented on 2022-08-25T06:34:41Z Made most/all of these changes. I linked to the Workbench section in the Vertex AI pricing guide separately from the link to the overall Vertex AI page. |
|
View / edit / reply to this conversation on ReviewNB aarondietz234 commented on 2022-08-25T04:07:17Z Nit: Just a branding suggestion--lowercase "notebooks", here and throughout this tutorial. If this is how it is in the template, disregard and someday I'll take a look at the template and suggest the change. alokpattani commented on 2022-08-25T06:40:29Z Went through and changed all "notebook" to lowercase except 1-2 where it goes with Jupyter (not Vertex) as something like a product title or display heading. |
|
View / edit / reply to this conversation on ReviewNB aarondietz234 commented on 2022-08-25T04:07:18Z Nit: Change "Vertex AI Notebook requires" to:
Vertex AI Workbench notebooks require alokpattani commented on 2022-08-25T06:40:51Z Done. |
|
View / edit / reply to this conversation on ReviewNB aarondietz234 commented on 2022-08-25T04:07:19Z Nit: Remove "off" from "save off some of the outputs..." alokpattani commented on 2022-08-25T06:41:07Z Done. |
|
View / edit / reply to this conversation on ReviewNB aarondietz234 commented on 2022-08-25T04:07:19Z Remove an 's' to change "a sets of dates" to "a set of dates". Or perhaps it should be "sets of dates" without the 'a' but I'm guessing it should be the first option. alokpattani commented on 2022-08-25T06:41:47Z Changed to "a set of dates" |
|
View / edit / reply to this conversation on ReviewNB aarondietz234 commented on 2022-08-25T04:07:20Z Grammar nit: Add an 'in' to "which you looked at the individual event..." to make it:
"which you looked at in the individual event..." alokpattani commented on 2022-08-25T06:43:32Z The point I was making was more intricate (adding the "in" wasn't technically correct, but I get why it felt like it could be), so I ended up re-wording a couple parts of this paragraph altogether - I think it flows better now. |
|
View / edit / reply to this conversation on ReviewNB aarondietz234 commented on 2022-08-25T04:07:21Z Add a space between the first and second sentences. alokpattani commented on 2022-08-25T06:43:51Z Done. |
|
Made most/all of these changes. View entire conversation on ReviewNB |
|
Went through and changed all "notebook" to lowercase except 1-2 where it goes with Jupyter (not Vertex) as something like a product title or display heading. View entire conversation on ReviewNB |
|
Done. View entire conversation on ReviewNB |
1 similar comment
|
Done. View entire conversation on ReviewNB |
|
Changed to "a set of dates" View entire conversation on ReviewNB |
|
The point I was making was more intricate (adding the "in" wasn't technically correct, but I get why it felt like it could be), so I ended up re-wording a couple parts of this paragraph altogether - I think it flows better now. View entire conversation on ReviewNB |
|
Done. View entire conversation on ReviewNB |
…form#885) * Create explore_data_in_bigquery_with_workbench.ipynb Adding in notebook for exploratory data analysis as part of "Data to AI" effort. See this Colab for what this notebook looks like after it is run: https://colab.research.google.com/drive/1JeNeMtj2A_5P5vo9wxSkrwHQM5JQSoAu. Submitting it with outputs shown since a lot of this about interactive visualization, which can inspire folks to use/read the notebook beyond just the code. * Update CODEOWNERS Adding owner for forthcoming exploratory data analysis notebook * Update CODEOWNERS * Updating exploratory data analysis notebook with latest updates from linter/review * Updated notebook formatting to try to pass format test * Trying again to pass notebook formatting test * Trying again to pass notebook formatting test * Trying again to pass notebook formatting test * Linted version of notebook & better project picker * Uploading linted version from ivanmkc@ * Update CODEOWNERS with EDA notebook * Updated notebook w/ Tech Writer edits, re-ran all * 1-2 minor text updates, try to pass linter again * Trying w/ updated linted file from ivanmkc@ Co-authored-by: Ivan Cheung <ivans.mailbox@gmail.com> Co-authored-by: Andrew Ferlitsch <aferlitsch@google.com>
Adding in notebook for exploratory data analysis as part of "Data to AI" effort. See this Colab for what this notebook looks like after it is run: https://colab.research.google.com/drive/1JeNeMtj2A_5P5vo9wxSkrwHQM5JQSoAu. Submitting it with outputs shown since a lot of this about interactive visualization, which can inspire folks to use/read the notebook beyond just the code.
REQUIRED: Fill out the below checklists or remove if irrelevant
Official Notebooksunder the notebooks/official folder, follow this mandatory checklist:Official Notebookssection, pointing to the author or the author's team.