Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for permsRepo without repository #79

Merged
merged 2 commits into from
Jul 20, 2020
Merged

fix: allow for permsRepo without repository #79

merged 2 commits into from
Jul 20, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jul 20, 2020

If someone publishes their first package with only repoPerms, it's not possible to publish again.

@bcoe bcoe requested a review from soldair July 20, 2020 19:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2020
src/lib/packument.ts Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #79 into master will increase coverage by 0.35%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   29.03%   29.39%   +0.35%     
==========================================
  Files          18       18              
  Lines        2228     2245      +17     
  Branches      105       94      -11     
==========================================
+ Hits          647      660      +13     
- Misses       1581     1585       +4     
Impacted Files Coverage Δ
src/lib/packument.ts 47.85% <72.72%> (+1.40%) ⬆️
src/lib/write-package.ts 73.41% <82.35%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782665e...e1180c8. Read the comment docs.

@bcoe bcoe merged commit f552d02 into master Jul 20, 2020
@bcoe bcoe deleted the fix-perms-repo branch July 20, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants