Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check more pages of tags #92

Merged
merged 2 commits into from
Feb 24, 2021
Merged

fix: check more pages of tags #92

merged 2 commits into from
Feb 24, 2021

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Dec 29, 2020

The GitHub API returns tags alphabetically, rather than chronologically, this means that in mono-repos we will potentially not find a tag if there have been more than 600 releases.

As a more permanent fix for this, I believe we should check both releases and tags, but this is a good start.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 29, 2020
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #92 (fcc6cf3) into master (e2686d1) will increase coverage by 2.82%.
The diff coverage is 87.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   29.03%   31.86%   +2.82%     
==========================================
  Files          18       19       +1     
  Lines        2228     2335     +107     
  Branches      105      126      +21     
==========================================
+ Hits          647      744      +97     
- Misses       1581     1591      +10     
Impacted Files Coverage Δ
src/server.ts 0.00% <0.00%> (ø)
src/lib/datastore.ts 30.88% <25.00%> (+0.02%) ⬆️
src/lib/packument.ts 47.85% <72.72%> (+1.40%) ⬆️
src/lib/write-package.ts 75.30% <90.90%> (+2.01%) ⬆️
src/lib/github.ts 67.77% <100.00%> (+5.77%) ⬆️
src/routes/put-delete-version.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf28d5...fcc6cf3. Read the comment docs.

@bcoe bcoe merged commit 4565a0c into master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants