Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ for Jib CLI #3118

Merged
merged 11 commits into from Mar 17, 2021
Merged

Update FAQ for Jib CLI #3118

merged 11 commits into from Mar 17, 2021

Conversation

mpeddada1
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #3118 (e84f683) into master (da38d49) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3118      +/-   ##
============================================
- Coverage     71.12%   71.08%   -0.04%     
- Complexity     2315     2320       +5     
============================================
  Files           278      280       +2     
  Lines          9790     9825      +35     
  Branches        991      992       +1     
============================================
+ Hits           6963     6984      +21     
- Misses         2482     2495      +13     
- Partials        345      346       +1     
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/google/cloud/tools/jib/cli/Jar.java 43.75% <0.00%> (-2.16%) 14.00% <0.00%> (ø%)
...ain/java/com/google/cloud/tools/jib/cli/Build.java 18.91% <0.00%> (-1.67%) 4.00% <0.00%> (ø%)
...ogle/cloud/tools/jib/api/JavaContainerBuilder.java 82.17% <0.00%> (-0.50%) 53.00% <0.00%> (-1.00%)
...m/google/cloud/tools/jib/cli/CommonCliOptions.java 96.55% <0.00%> (ø) 40.00% <0.00%> (ø%)
.../google/cloud/tools/jib/cli/logging/Verbosity.java 91.66% <0.00%> (ø) 4.00% <0.00%> (ø%)
...b/plugins/common/PluginConfigurationProcessor.java 63.87% <0.00%> (ø) 65.00% <0.00%> (ø%)
.../cloud/tools/jib/cli/ShortErrorMessageHandler.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...le/cloud/tools/jib/cli/logging/HttpTraceLevel.java 87.50% <0.00%> (ø) 2.00% <0.00%> (?%)
...oud/tools/jib/builder/steps/PullBaseImageStep.java 62.05% <0.00%> (+0.27%) 20.00% <0.00%> (ø%)
...le/cloud/tools/jib/configuration/BuildContext.java 82.89% <0.00%> (+0.65%) 18.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da38d49...e84f683. Read the comment docs.

docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Show resolved Hide resolved
docs/faq.md Show resolved Hide resolved
@chanseokoh
Copy link
Member

When changing titles, don't forget to update the ToC and link refs.

docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
@mpeddada1
Copy link
Contributor Author

Yup, I totally agree with these thoughts. Specifying the limitation of the current support for fat JARs will offer a lot of clarity.

docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one minor comment.

And please test the new ToC links after merging. (I made a mistake with the Jib config FAQ before, if you remember 😄)

docs/faq.md Outdated Show resolved Hide resolved
@mpeddada1
Copy link
Contributor Author

And please test the new ToC links after merging. (I made a mistake with the Jib config FAQ before, if you remember 😄)

Thanks for the heads up! Verified the links to make sure they were okay:)

@mpeddada1 mpeddada1 merged commit 5cfc9c8 into master Mar 17, 2021
@mpeddada1 mpeddada1 deleted the update-faq-cli branch March 17, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants