Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete repository secret on unregistering repository #75

Conversation

4molybdenum2
Copy link
Contributor

Signed-off-by: Tathagata Paul tathagatapaul7@gmail.com

This PR will automatically delete repository secret on unregistering the repository.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 22, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@google-cla
Copy link

google-cla bot commented Jul 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@4molybdenum2 4molybdenum2 changed the title Delete repository secret on unregistering repository feat: delete repository secret on unregistering repository Jul 22, 2022
Copy link
Collaborator

@ChristopherFry ChristopherFry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating the pull request! I left a comment in the code with two scenarios we'll need to make sure we take into consideration. Additionally, be sure to complete the CLA if you haven't already. Without this, I won't be able to merge your changes.

@4molybdenum2 4molybdenum2 changed the title feat: delete repository secret on unregistering repository delete repo secret on unregister repository Jul 26, 2022
Signed-off-by: Tathagata Paul <tathagatapaul7@gmail.com>
@4molybdenum2
Copy link
Contributor Author

👍

Signed-off-by: Tathagata Paul <tathagatapaul7@gmail.com>
@ChristopherFry ChristopherFry changed the title delete repo secret on unregister repository feat: delete repository secret on unregistering repository Jul 27, 2022
@ChristopherFry ChristopherFry merged commit 6f9106b into GoogleContainerTools:main Jul 28, 2022
@release-please release-please bot mentioned this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants