-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete repository secret on unregistering repository #75
feat: delete repository secret on unregistering repository #75
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for creating the pull request! I left a comment in the code with two scenarios we'll need to make sure we take into consideration. Additionally, be sure to complete the CLA if you haven't already. Without this, I won't be able to merge your changes.
plugins/cad/src/components/RepositoryPage/components/AdvancedRepositoryOptions.tsx
Outdated
Show resolved
Hide resolved
plugins/cad/src/components/RepositoryPage/components/AdvancedRepositoryOptions.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Tathagata Paul <tathagatapaul7@gmail.com>
6923bb5
to
06b425a
Compare
plugins/cad/src/components/RepositoryPage/components/AdvancedRepositoryOptions.tsx
Outdated
Show resolved
Hide resolved
plugins/cad/src/components/RepositoryPage/components/AdvancedRepositoryOptions.tsx
Outdated
Show resolved
Hide resolved
👍 |
Signed-off-by: Tathagata Paul <tathagatapaul7@gmail.com>
0be93c3
to
ff853e0
Compare
'checkUsedByOtherRepository' was used before it was defined
Signed-off-by: Tathagata Paul tathagatapaul7@gmail.com
This PR will automatically delete repository secret on unregistering the repository.